From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jinyoung CHOI <j-young.choi@samsung.com>
Cc: "hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: (2) [PATCH 2/2] nvme-pci: fix metadata mapping length
Date: Wed, 12 Apr 2023 21:37:04 -0400 [thread overview]
Message-ID: <yq13554bm4l.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230412071230epcms2p145d53bfc8e40eede25f282b80247218c@epcms2p1> (Jinyoung CHOI's message of "Wed, 12 Apr 2023 16:12:30 +0900")
Jinyoung,
> I think the problem is bio_integrity_add_page(). If it is modified,
> sg functions for blk-integrity should also be modified.
The bio integrity scatterlist handling predates NVMe and wasn't written
with the single segment use case in mind. For SCSI we required the
hardware to support an integrity segment per data segment.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-04-13 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230412052443epcms2p836b669a12c4e81368bec2cd340656f73@epcms2p8>
2023-04-12 5:24 ` [PATCH 2/2] nvme-pci: fix metadata mapping length Jinyoung CHOI
2023-04-12 6:57 ` hch
2023-04-12 7:12 ` Jinyoung CHOI
2023-04-12 11:49 ` (2) " hch
2023-04-13 1:37 ` Martin K. Petersen [this message]
2023-04-13 2:19 ` Jinyoung CHOI
2023-04-13 2:26 ` (2) " Martin K. Petersen
2023-04-13 1:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq13554bm4l.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@fb.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=j-young.choi@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox