* [PATCH] st: remove redundant pointer STbuffer
@ 2018-08-03 10:47 Colin King
2018-08-05 9:14 ` "Kai Mäkisara (Kolumbus)"
2018-08-09 1:16 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-08-03 10:47 UTC (permalink / raw)
To: Kai Mäkisara, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer STbuffer is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/st.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 50c66ccc4b41..307df2fa39a3 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -828,11 +828,8 @@ static int st_flush_write_buffer(struct scsi_tape * STp)
static int flush_buffer(struct scsi_tape *STp, int seek_next)
{
int backspace, result;
- struct st_buffer *STbuffer;
struct st_partstat *STps;
- STbuffer = STp->buffer;
-
/*
* If there was a bus reset, block further access
* to this device.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] st: remove redundant pointer STbuffer
2018-08-03 10:47 [PATCH] st: remove redundant pointer STbuffer Colin King
@ 2018-08-05 9:14 ` "Kai Mäkisara (Kolumbus)"
2018-08-09 1:16 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: "Kai Mäkisara (Kolumbus)" @ 2018-08-05 9:14 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
> On 3 Aug 2018, at 13.47, Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer STbuffer is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Has been unused at least since 2005 :-)
Thanks,
Kai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] st: remove redundant pointer STbuffer
2018-08-03 10:47 [PATCH] st: remove redundant pointer STbuffer Colin King
2018-08-05 9:14 ` "Kai Mäkisara (Kolumbus)"
@ 2018-08-09 1:16 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-08-09 1:16 UTC (permalink / raw)
To: Colin King
Cc: Kai Mäkisara, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> Pointer STbuffer is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-09 2:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-03 10:47 [PATCH] st: remove redundant pointer STbuffer Colin King
2018-08-05 9:14 ` "Kai Mäkisara (Kolumbus)"
2018-08-09 1:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox