Re: [PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

jianchao.wang
2018-03-02T02:18:19Z

Hi martin

On 03/02/2018 09:44 AM, Martin K. Petersen wrote:
>> In scsi core, __scsi_queue_insert should just put request back on the
>> queue and retry using the same command as before. However, for blk-mq,
>> scsi_mq_requeue_cmd is employed here which will unprepare the
>> request. To align with the semantics of __scsi_queue_insert, use
>> blk_mq_requeue_request with kick_requeue_list == true and put the
>> reference of scsi_device.
>>
>> V1 -> V2:
>> - add put_device on scsi_device->sdev_gendev
> Also, please put changelog after the --- delimiter.
>

Yes, I will modify this next version.

Thanks
Jianchao