From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B36C43382 for ; Fri, 28 Sep 2018 06:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22A692173D for ; Fri, 28 Sep 2018 06:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="4pHskS2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22A692173D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbeI1Mxu (ORCPT ); Fri, 28 Sep 2018 08:53:50 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:48814 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbeI1Mxu (ORCPT ); Fri, 28 Sep 2018 08:53:50 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8S6SiXO101171; Fri, 28 Sep 2018 06:31:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=wQvGOtGP+Jb/WKx1uzQyCUVlbcoJ2NhSMZLipV83EHw=; b=4pHskS2W8aJytDq+m/txphvg8q98LwlLRdbpg8tNU50U6NZkpC+GmM5XNxEvVkYH/mJa /AIxBK2pR7xGKt0PzGkZkJpmARHjxCJtaI2792TGD7aMzLFwQRwuQM5YRoi2Sd7kpJVz mWVTU/Egc64A2RiJLGAcOuKKzD9z91jb45Gylb8Zjgi+HXwYSMj0kHAgMyi2ht5dY2l8 bCF3/ElI5KSYgk+js1+iJg1G3JXXtn7EwVy56zb+ntIQI3U1OotcMS0Uqokw7eUbEG1r GJsbSTAmjUt6XZNTR3K+4Eo3iWOXKIPiZ15ZQNjj7CoL0Rjepd+9nKuTJQlKFYUGW6vo oQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2mnvtv4t05-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Sep 2018 06:31:33 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8S6VWUQ007532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Sep 2018 06:31:33 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w8S6VWdP009638; Fri, 28 Sep 2018 06:31:32 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 27 Sep 2018 23:31:32 -0700 To: Nathan Chancellor Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180915063645.31295-1-natechancellor@gmail.com> Date: Fri, 28 Sep 2018 02:31:29 -0400 In-Reply-To: <20180915063645.31295-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Fri, 14 Sep 2018 23:36:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9029 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=764 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809280070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan, > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering