* [PATCH] [SCSI] fnic: use kzalloc in fnic_fcoe_process_vlan_resp
@ 2015-10-01 19:59 Rasmus Villemoes
2015-10-02 7:05 ` Johannes Thumshirn
0 siblings, 1 reply; 4+ messages in thread
From: Rasmus Villemoes @ 2015-10-01 19:59 UTC (permalink / raw)
To: Hiral Patel, Suma Ramars, Brian Uchino, James E.J. Bottomley
Cc: Rasmus Villemoes, linux-scsi, linux-kernel
This saves a little .text and avoids the sizeof(...) style
inconsistency.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/scsi/fnic/fnic_fcs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index bf0bbd42efb5..2d013076bfba 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -415,15 +415,13 @@ static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *skb)
vid = ntohs(((struct fip_vlan_desc *)desc)->fd_vlan);
shost_printk(KERN_INFO, fnic->lport->host,
"process_vlan_resp: FIP VLAN %d\n", vid);
- vlan = kmalloc(sizeof(*vlan),
- GFP_ATOMIC);
+ vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC);
if (!vlan) {
/* retry from timer */
spin_unlock_irqrestore(&fnic->vlans_lock,
flags);
goto out;
}
- memset(vlan, 0, sizeof(struct fcoe_vlan));
vlan->vid = vid & 0x0fff;
vlan->state = FIP_VLAN_AVAIL;
list_add_tail(&vlan->list, &fnic->vlans);
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] fnic: use kzalloc in fnic_fcoe_process_vlan_resp
2015-10-01 19:59 [PATCH] [SCSI] " Rasmus Villemoes
@ 2015-10-02 7:05 ` Johannes Thumshirn
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2015-10-02 7:05 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Hiral Patel, Suma Ramars, Brian Uchino, James E.J. Bottomley,
linux-scsi, linux-kernel
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
> This saves a little .text and avoids the sizeof(...) style
> inconsistency.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/scsi/fnic/fnic_fcs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
> index bf0bbd42efb5..2d013076bfba 100644
> --- a/drivers/scsi/fnic/fnic_fcs.c
> +++ b/drivers/scsi/fnic/fnic_fcs.c
> @@ -415,15 +415,13 @@ static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *skb)
> vid = ntohs(((struct fip_vlan_desc *)desc)->fd_vlan);
> shost_printk(KERN_INFO, fnic->lport->host,
> "process_vlan_resp: FIP VLAN %d\n", vid);
> - vlan = kmalloc(sizeof(*vlan),
> - GFP_ATOMIC);
> + vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC);
> if (!vlan) {
> /* retry from timer */
> spin_unlock_irqrestore(&fnic->vlans_lock,
> flags);
> goto out;
> }
> - memset(vlan, 0, sizeof(struct fcoe_vlan));
> vlan->vid = vid & 0x0fff;
> vlan->state = FIP_VLAN_AVAIL;
> list_add_tail(&vlan->list, &fnic->vlans);
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp
@ 2018-01-08 23:11 Rasmus Villemoes
2018-01-17 5:55 ` Martin K. Petersen
0 siblings, 1 reply; 4+ messages in thread
From: Rasmus Villemoes @ 2018-01-08 23:11 UTC (permalink / raw)
To: Satish Kharat, Sesidhar Baddela, Karan Tilak Kumar,
James E.J. Bottomley, Martin K. Petersen
Cc: Rasmus Villemoes, linux-scsi, linux-kernel
This saves a little .text and gets rid of the unmotivated line break and
the sizeof(...) style inconsistency.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/scsi/fnic/fnic_fcs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index 999fc7547560..c7bf316d8e83 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -442,15 +442,13 @@ static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *skb)
vid = ntohs(((struct fip_vlan_desc *)desc)->fd_vlan);
shost_printk(KERN_INFO, fnic->lport->host,
"process_vlan_resp: FIP VLAN %d\n", vid);
- vlan = kmalloc(sizeof(*vlan),
- GFP_ATOMIC);
+ vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC);
if (!vlan) {
/* retry from timer */
spin_unlock_irqrestore(&fnic->vlans_lock,
flags);
goto out;
}
- memset(vlan, 0, sizeof(struct fcoe_vlan));
vlan->vid = vid & 0x0fff;
vlan->state = FIP_VLAN_AVAIL;
list_add_tail(&vlan->list, &fnic->vlans);
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp
2018-01-08 23:11 [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp Rasmus Villemoes
@ 2018-01-17 5:55 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2018-01-17 5:55 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Satish Kharat, Sesidhar Baddela, Karan Tilak Kumar,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Rasmus,
> This saves a little .text and gets rid of the unmotivated line break and
> the sizeof(...) style inconsistency.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-17 5:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 23:11 [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp Rasmus Villemoes
2018-01-17 5:55 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2015-10-01 19:59 [PATCH] [SCSI] " Rasmus Villemoes
2015-10-02 7:05 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox