From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Boaz Harrosh <ooo@electrozaur.com>,
Benny Halevy <bhalevy@primarydata.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check
Date: Mon, 27 Mar 2017 21:54:48 -0400 [thread overview]
Message-ID: <yq14lye6u8n.fsf@oracle.com> (raw)
In-Reply-To: <20170323104142.GD20154@mwanda> (Dan Carpenter's message of "Thu, 23 Mar 2017 13:41:42 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> We don't call the remove() function unless probe() succeeds so "oud"
> can't be NULL here. Plus, if it were NULL, we dereference it on the
> next line so it would crash anyway.
Applied to 4.12/scsi-queue (by hand).
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-03-28 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 10:41 [PATCH] scsi: osd_uld: remove an unneeded NULL check Dan Carpenter
2017-03-23 19:38 ` Boaz Harrosh
2017-03-28 1:54 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14lye6u8n.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bhalevy@primarydata.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ooo@electrozaur.com \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox