From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-scsi@vger.kernel.org,
Karan Tilak Kumar <kartilak@cisco.com>,
Sesidhar Baddela <sebaddel@cisco.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: snic: fix memory leak with using debugfs_lookup()
Date: Wed, 08 Feb 2023 18:50:53 -0500 [thread overview]
Message-ID: <yq15ycbzphb.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230202141009.2290380-1-gregkh@linuxfoundation.org> (Greg Kroah-Hartman's message of "Thu, 2 Feb 2023 15:10:09 +0100")
Greg,
> When calling debugfs_lookup() the result must have dput() called on
> it, otherwise the memory will leak over time. To make things simpler,
> just call debugfs_lookup_and_remove() instead which handles all of the
> logic at once.
Applied to 6.3/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-02-08 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:10 [PATCH] scsi: snic: fix memory leak with using debugfs_lookup() Greg Kroah-Hartman
2023-02-08 23:50 ` Martin K. Petersen [this message]
2023-02-09 12:27 ` Greg Kroah-Hartman
2023-02-14 16:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15ycbzphb.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox