From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: <martin.petersen@oracle.com>, <axboe@kernel.dk>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function
Date: Wed, 14 Jan 2015 15:22:36 -0500 [thread overview]
Message-ID: <yq161c9w1rn.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <54B6C7E4.6010002@micron.com> (Sam Bradshaw's message of "Wed, 14 Jan 2015 11:47:48 -0800")
>>>>> "Sam" == Sam Bradshaw <sbradshaw@micron.com> writes:
Hey Sam,
Sam> The prot_buf pointer passed to the generate/verify functions is
Sam> incorrect for the second and subsequent range, making it impossible
Sam> to verify the guard tag. The patch correctly increments the
Sam> prot_buf pointer by the tuple size for each pass.
prot_buf is just a temporary variable used to get the kernel address of
the buffer pointer. We only care about iter.prot_buf and that gets
incremented by the generate or verify functions.
Are your data buffers page aligned? Things are going to break if they
aren't...
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2015-01-14 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 19:47 [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function Sam Bradshaw
2015-01-14 20:22 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq161c9w1rn.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox