From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbaKZE51 (ORCPT ); Tue, 25 Nov 2014 23:57:27 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:44830 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbaKZE5Z (ORCPT ); Tue, 25 Nov 2014 23:57:25 -0500 To: "Darrick J. Wong" Cc: Jens Axboe , "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-fsdevel Subject: Re: [PATCH v2] block: fix regression where bio_integrity_process uses wrong bio_vec iterator From: "Martin K. Petersen" Organization: Oracle Corporation References: <20141126014025.GD10050@birch.djwong.org> Date: Tue, 25 Nov 2014 23:57:18 -0500 In-Reply-To: <20141126014025.GD10050@birch.djwong.org> (Darrick J. Wong's message of "Tue, 25 Nov 2014 17:40:25 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Darrick" == Darrick J Wong writes: Darrick> Therefore, teach bio_integrity_process() to use Darrick> bio_for_each_segment() to iterate the bio_vecs, since the Darrick> per-bio iterator tracks which bio_vecs are associated with that Darrick> particular bio. The integrity handling code is effectively Darrick> part of the "driver" (it's not the bio owner), so it must use Darrick> the correct iterator function. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering