[PATCH] scsi: iscsi: Remove unused iscsi_create_session

[PATCH] scsi: iscsi: Remove unused iscsi_create_session

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

iscsi_create_session() last use was removed in 2008 by
commit 756135215ec7 ("[SCSI] iscsi: remove session and host binding in
libiscsi")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/scsi_transport_iscsi.c | 27 ---------------------------
 include/scsi/scsi_transport_iscsi.h |  4 ----
 2 files changed, 31 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index fde7de3b1e55..8fc5e0aa5eaf 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -2122,33 +2122,6 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
 }
 EXPORT_SYMBOL_GPL(iscsi_add_session);
 
-/**
- * iscsi_create_session - create iscsi class session
- * @shost: scsi host
- * @transport: iscsi transport
- * @dd_size: private driver data size
- * @target_id: which target
- *
- * This can be called from a LLD or iscsi_transport.
- */
-struct iscsi_cls_session *
-iscsi_create_session(struct Scsi_Host *shost, struct iscsi_transport *transport,
-		     int dd_size, unsigned int target_id)
-{
-	struct iscsi_cls_session *session;
-
-	session = iscsi_alloc_session(shost, transport, dd_size);
-	if (!session)
-		return NULL;
-
-	if (iscsi_add_session(session, target_id)) {
-		iscsi_free_session(session);
-		return NULL;
-	}
-	return session;
-}
-EXPORT_SYMBOL_GPL(iscsi_create_session);
-
 static void iscsi_conn_release(struct device *dev)
 {
 	struct iscsi_cls_conn *conn = iscsi_dev_to_conn(dev);
diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h
index bd1243657c01..5474494a1e99 100644
--- a/include/scsi/scsi_transport_iscsi.h
+++ b/include/scsi/scsi_transport_iscsi.h
@@ -447,10 +447,6 @@ extern int iscsi_add_session(struct iscsi_cls_session *session,
 			     unsigned int target_id);
 extern int iscsi_session_event(struct iscsi_cls_session *session,
 			       enum iscsi_uevent_e event);
-extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost,
-						struct iscsi_transport *t,
-						int dd_size,
-						unsigned int target_id);
 extern void iscsi_force_destroy_session(struct iscsi_cls_session *session);
 extern void iscsi_remove_session(struct iscsi_cls_session *session);
 extern void iscsi_free_session(struct iscsi_cls_session *session);
-- 
2.47.1

Re: [PATCH] scsi: iscsi: Remove unused iscsi_create_session

[Martin K. Petersen]

> iscsi_create_session() last use was removed in 2008 by commit
> 756135215ec7 ("[SCSI] iscsi: remove session and host binding in
> libiscsi")

Applied to 6.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: iscsi: Remove unused iscsi_create_session

[Martin K. Petersen]

On Mon, 23 Dec 2024 18:01:10 +0000, linux@treblig.org wrote:

> iscsi_create_session() last use was removed in 2008 by
> commit 756135215ec7 ("[SCSI] iscsi: remove session and host binding in
> libiscsi")
> 
> Remove it.
> 
> 
> [...]

Applied to 6.14/scsi-queue, thanks!

[1/1] scsi: iscsi: Remove unused iscsi_create_session
      https://git.kernel.org/mkp/scsi/c/6e67b32087e3

-- 
Martin K. Petersen	Oracle Linux Engineering