* [PATCH] qla2xxx: edif: remove unneeded variable
@ 2022-04-26 7:43 Guo Zhengkui
2022-04-26 12:57 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Guo Zhengkui @ 2022-04-26 7:43 UTC (permalink / raw)
To: Nilesh Javali, supporter:QLOGIC QLA2XXX FC-SCSI DRIVER,
James E.J. Bottomley, Martin K. Petersen,
open list:QLOGIC QLA2XXX FC-SCSI DRIVER, open list
Cc: zhengkui_guo, Guo Zhengkui
Fix the following coccicheck warning:
drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval".
Return "0" on line 761.
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/scsi/qla2xxx/qla_edif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index 0628633c7c7e..cb8145a9ac09 100644
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -657,7 +657,6 @@ qla_edif_app_chk_sa_update(scsi_qla_host_t *vha, fc_port_t *fcport,
static int
qla_edif_app_authok(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
{
- int32_t rval = 0;
struct auth_complete_cmd appplogiok;
struct app_plogi_reply appplogireply = {0};
struct fc_bsg_reply *bsg_reply = bsg_job->reply;
@@ -758,7 +757,7 @@ qla_edif_app_authok(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
&appplogireply,
sizeof(struct app_plogi_reply));
- return rval;
+ return 0;
}
/**
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qla2xxx: edif: remove unneeded variable
2022-04-26 7:43 [PATCH] qla2xxx: edif: remove unneeded variable Guo Zhengkui
@ 2022-04-26 12:57 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-04-26 12:57 UTC (permalink / raw)
To: Guo Zhengkui
Cc: Nilesh Javali, supporter:QLOGIC QLA2XXX FC-SCSI DRIVER,
James E.J. Bottomley, Martin K. Petersen,
open list:QLOGIC QLA2XXX FC-SCSI DRIVER, open list, zhengkui_guo
Guo,
> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval".
> Return "0" on line 761.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qla2xxx: edif: remove unneeded variable
2022-04-26 7:43 [PATCH] qla2xxx: edif: remove unneeded variable Guo Zhengkui
2022-04-26 12:57 ` Martin K. Petersen
@ 2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: James E.J. Bottomley, open list, Nilesh Javali,
open list:QLOGIC QLA2XXX FC-SCSI DRIVER,
supporter:QLOGIC QLA2XXX FC-SCSI DRIVER, Guo Zhengkui
Cc: Martin K . Petersen, zhengkui_guo
On Tue, 26 Apr 2022 15:43:34 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval".
> Return "0" on line 761.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] qla2xxx: edif: remove unneeded variable
https://git.kernel.org/mkp/scsi/c/1497e95e22c3
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-03 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-26 7:43 [PATCH] qla2xxx: edif: remove unneeded variable Guo Zhengkui
2022-04-26 12:57 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox