From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org, Klaus Jensen <k.jensen@samsung.com>
Subject: Re: [PATCH] nvme: fix write zeroes pi
Date: Thu, 04 Nov 2021 23:23:25 -0400 [thread overview]
Message-ID: <yq17ddnp9s9.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20211104181618.864157-1-its@irrelevant.dk> (Klaus Jensen's message of "Thu, 4 Nov 2021 19:16:18 +0100")
Klaus,
> Write Zeroes sets PRACT when block integrity is enabled (as it
> should), but neglects to also set the reftag which is expected by
> reads. This causes protection errors on reads.
>
> Fix this by setting the reftag for type 1 and 2 (for type 3, reads
> will not check the reftag).
The NVMe spec now clarifies that ILBRT is not inferred for Type 1 so
that looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-11-05 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:16 [PATCH] nvme: fix write zeroes pi Klaus Jensen
2021-11-05 3:23 ` Martin K. Petersen [this message]
2021-11-10 6:10 ` Chaitanya Kulkarni
2021-11-10 9:16 ` Klaus Jensen
2021-11-11 5:06 ` Chaitanya Kulkarni
2021-11-10 8:43 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17ddnp9s9.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox