* [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue
@ 2018-08-08 6:24 Jianchao Wang
2018-08-08 9:25 ` Ming Lei
2018-08-09 2:02 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jianchao Wang @ 2018-08-08 6:24 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
We don't use blk-mq start/stop hw queue any more, so no reason to
use blk_mq_start_hw_queues which does clear_bit, replace it with
blk_mq_run_hw_queues.
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 41e9ac9..7de0f26 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -371,7 +371,7 @@ void scsi_device_unbusy(struct scsi_device *sdev)
static void scsi_kick_queue(struct request_queue *q)
{
if (q->mq_ops)
- blk_mq_start_hw_queues(q);
+ blk_mq_run_hw_queues(q, false);
else
blk_run_queue(q);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue
2018-08-08 6:24 [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue Jianchao Wang
@ 2018-08-08 9:25 ` Ming Lei
2018-08-09 2:02 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2018-08-08 9:25 UTC (permalink / raw)
To: Jianchao Wang
Cc: James Bottomley, Martin K. Petersen, Linux SCSI List,
Linux Kernel Mailing List, Ming Lei
On Wed, Aug 8, 2018 at 2:24 PM, Jianchao Wang
<jianchao.w.wang@oracle.com> wrote:
> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 41e9ac9..7de0f26 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -371,7 +371,7 @@ void scsi_device_unbusy(struct scsi_device *sdev)
> static void scsi_kick_queue(struct request_queue *q)
> {
> if (q->mq_ops)
> - blk_mq_start_hw_queues(q);
> + blk_mq_run_hw_queues(q, false);
> else
> blk_run_queue(q);
> }
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming Lei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue
2018-08-08 6:24 [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue Jianchao Wang
2018-08-08 9:25 ` Ming Lei
@ 2018-08-09 2:02 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-08-09 2:02 UTC (permalink / raw)
To: Jianchao Wang; +Cc: jejb, martin.petersen, linux-scsi, linux-kernel
Jianchao,
> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-09 2:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 6:24 [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue Jianchao Wang
2018-08-08 9:25 ` Ming Lei
2018-08-09 2:02 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox