From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: lduncan@suse.com, cleech@redhat.com
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, open-iscsi@googlegroups.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()
Date: Thu, 15 Mar 2018 00:11:02 -0400 [thread overview]
Message-ID: <yq17eqe9dwp.fsf@oracle.com> (raw)
In-Reply-To: <a77739e256b044c2e125e106165efc751ce4a0f6.1520422535.git.arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Wed, 7 Mar 2018 17:07:33 +0530")
> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.
Lee, Chris: Please review!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-03-15 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 11:37 [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree() Arvind Yadav
2018-03-15 4:11 ` Martin K. Petersen [this message]
2018-03-15 17:44 ` Chris Leech
2018-03-17 9:37 ` arvindY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17eqe9dwp.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox