From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbeBWBtg (ORCPT ); Thu, 22 Feb 2018 20:49:36 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55508 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbeBWBte (ORCPT ); Thu, 22 Feb 2018 20:49:34 -0500 To: , Cc: , , , , , , Xiaofei Tan Subject: Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation From: "Martin K. Petersen" Organization: Oracle Corporation References: <1519067611-206638-1-git-send-email-john.garry@huawei.com> <1519067611-206638-2-git-send-email-john.garry@huawei.com> Date: Thu, 22 Feb 2018 20:49:17 -0500 In-Reply-To: <1519067611-206638-2-git-send-email-john.garry@huawei.com> (John Garry's message of "Tue, 20 Feb 2018 03:13:24 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8812 signatures=668677 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=601 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802230018 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Xiaofei Tan > > For some new boards with hip07 chipset we are required to > set PHY config registers differently. The hw property which > determines how to set these registers is in the PHY signal > attenuation readings. > > This patch add an devicetree property, signal-attenuation, which > is used to describe the signal attenuation of an board. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Xiaofei Tan > Signed-off-by: John Garry > --- > Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt > index df3bef7..bd32ecd 100644 > --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt > +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt > @@ -53,6 +53,13 @@ Main node required properties: > Optional main node properties: > - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the > "am-max-transmissions" limitation. > + - signal-attenuation : array of 3 32-bit values, containing de-emphasis, > + preshoot, and boost attenuation readings for the board. They > + are used to describe the signal attenuation of the board. These > + values' range is 7600 to 12400, and used to represent -24dB to > + 24dB. > + The formula is "y = (x-10000)/10000". For example, 10478 > + means 4.78dB. > > Example: > sas0: sas@c1000000 { Rob/Mark: Please review! -- Martin K. Petersen Oracle Linux Engineering