From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751035AbdKGEDb (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 23:03:31 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:48920 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750760AbdKGEDa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 23:03:30 -0500
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
        Chaitra P B <chaitra.basappa@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Tomas Henzl <thenzl@redhat.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Hannes Reinecke <hare@suse.de>,
        Romain Perier <romain.perier@collabora.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mpt3sas: fix dma_addr_t casts
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20171106133540.506572-1-arnd@arndb.de>
Date: Mon, 06 Nov 2017 23:03:00 -0500
In-Reply-To: <20171106133540.506572-1-arnd@arndb.de> (Arnd Bergmann's message
        of "Mon, 6 Nov 2017 14:35:16 +0100")
Message-ID: <yq17ev23fd7.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Arnd,

> After taking a closer look, I found that the problem is that the new
> code mixes up pointers and dma_addr_t values unnecessarily.
>
> This changes it to use the correct types consistently, which lets us
> get rid of a lot of type casts in the process. I'm also renaming some
> variables to avoid confusion between physical and dma address spaces
> that are often distinct.

Nice work! Applied to 4.15/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering