From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Nick Spooner <nicholas.spooner@seagate.com>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: Use string_choices to fix Coccinelle warnings
Date: Sun, 26 Apr 2026 21:35:43 -0400 [thread overview]
Message-ID: <yq18qa9i3t1.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <2334cec9-c80f-4fe5-a2e9-e35d4dfddbba@acm.org> (Bart Van Assche's message of "Thu, 23 Apr 2026 16:55:47 -0700")
Bart,
> My opinion is that the sd code is easier to read *without* this patch.
Yep, I agree.
--
Martin K. Petersen
prev parent reply other threads:[~2026-04-27 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 21:16 [PATCH] scsi: sd: Use string_choices to fix Coccinelle warnings Nick Spooner
2026-04-23 23:55 ` Bart Van Assche
2026-04-27 1:35 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18qa9i3t1.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nicholas.spooner@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox