From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Haoqian He <haoqian.he@smartx.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-kernel@vger.kernel.org (open list),
linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM),
"Martin K. Petersen" <martin.petersen@oracle.com>,
fengli@smartx.com
Subject: Re: [PATCH 1/3] scsi: sd: disable discard when set target full provisioning
Date: Tue, 02 Jul 2024 22:31:07 -0400 [thread overview]
Message-ID: <yq18qyjciuj.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240702030118.2198570-2-haoqian.he@smartx.com> (Haoqian He's message of "Mon, 1 Jul 2024 23:01:14 -0400")
Haoqian,
> + if (!sdkp->lbpvpd)
> + /* Disable discard if LBP VPD page not provided */
> + return SD_LBP_DISABLE;
That is not a valid assumption. Many devices which support thin
provisioning either predate the LBP VPD being defined or have decided
not to support that page. The current heuristics are very deliberate.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-03 2:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 3:01 [PATCH 0/3] scsi: disable discard when set target full provisioning Haoqian He
2024-07-02 3:01 ` [PATCH 1/3] scsi: sd: " Haoqian He
2024-07-03 2:31 ` Martin K. Petersen [this message]
2024-07-02 3:01 ` [PATCH 2/3] scsi: sd: remove scsi_disk field lbpvpd Haoqian He
2024-07-02 3:30 ` Damien Le Moal
2024-07-02 3:01 ` [PATCH 3/3] scsi: sd: remove some redundant initialization code Haoqian He
2024-07-02 3:33 ` Damien Le Moal
2024-07-04 3:01 ` Haoqian He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18qyjciuj.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=fengli@smartx.com \
--cc=haoqian.he@smartx.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox