From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: azeemshaikh38@gmail.com, Adam Radford <aradford@gmail.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, jejb@linux.ibm.com,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
Date: Mon, 22 May 2023 18:41:58 -0400 [thread overview]
Message-ID: <yq18rdgm1mo.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <168478437626.244538.8257051598276343700.b4-ty@chromium.org> (Kees Cook's message of "Mon, 22 May 2023 12:39:37 -0700")
Kees,
> On Wed, 17 May 2023 14:29:55 +0000, Azeem Shaikh wrote:
>> strlcpy() reads the entire source buffer first.
>> This read may exceed the destination size limit.
>> This is both inefficient and can lead to linear read
>> overflows if a source string is not NUL-terminated [1].
>> In an effort to remove strlcpy() completely [2], replace
>> strlcpy() here with strscpy().
>> No return values were used, so direct replacement is safe.
>>
>> [...]
>
> Applied to for-next/hardening, thanks!
>
> [1/1] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
> https://git.kernel.org/kees/c/fa36c95739ab
Are you planning on sending these? That's fine with me, just need to
know if I should close them in patchwork...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-05-22 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 14:29 [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-17 19:13 ` Kees Cook
2023-05-22 19:39 ` Kees Cook
2023-05-22 22:41 ` Martin K. Petersen [this message]
2023-05-23 1:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18rdgm1mo.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=aradford@gmail.com \
--cc=azeemshaikh38@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox