From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
james.bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, brking@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions
Date: Mon, 16 Nov 2020 22:22:37 -0500 [thread overview]
Message-ID: <yq18sb07l17.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <7df9d768-e008-a849-5fbd-78d6bd0536fa@linux.ibm.com> (Tyrel Datwyler's message of "Fri, 13 Nov 2020 11:39:35 -0800")
Tyrel,
> The checkpatch script only warns at 100 char lines these days. To be
> fair though I did have two lines go over that limit by a couple
> characters, there are a couple commit log typos, and I had an if
> keyword with no space after before the opening parenthesis. So, I'll
> happily re-spin.
Please tweak the little things that need fixing and resubmit.
> However, for my info going forward is the SCSI subsystem sticking to
> 80 char lines as a hard limit?
As far as I'm concerned the 80 char limit is mainly about ensuring that
the code is structured in a sensible way. Typesetting best practices
also suggest that longer lines are harder to read. So while I generally
don't strictly enforce the 80 char limit for drivers, I do push back if
I feel that readability could be improved by breaking the line or
restructuring the code.
Use your best judgment to optimize for readability.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-11-17 3:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 1:04 [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions Tyrel Datwyler
2020-11-12 1:04 ` [PATCH 2/6] ibmvfc: deduplicate common ibmvfc_cmd init code Tyrel Datwyler
2020-11-12 1:04 ` [PATCH 3/6] ibmvfc: add new fields for version 2 of several MADs Tyrel Datwyler
2020-11-17 22:06 ` Brian King
2020-11-18 0:28 ` Tyrel Datwyler
2020-11-12 1:04 ` [PATCH 4/6] ibmvfc: add FC payload retrieval routines for versioned vfcFrames Tyrel Datwyler
2020-11-17 22:14 ` Brian King
2020-11-17 22:21 ` Brian King
2020-11-18 0:39 ` Tyrel Datwyler
2020-11-18 0:34 ` Tyrel Datwyler
2020-11-12 1:04 ` [PATCH 5/6] ibmvfc: add support for targetWWPN field in v2 MADs and vfcFrame Tyrel Datwyler
2020-11-12 1:04 ` [PATCH 6/6] ibmvfc: advertise client support for targetWWPN using v2 commands Tyrel Datwyler
2020-11-17 22:23 ` Brian King
2020-11-12 9:37 ` [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions Christoph Hellwig
2020-11-13 19:39 ` Tyrel Datwyler
2020-11-17 3:22 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18sb07l17.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@linux.ibm.com \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox