From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E6DC38A30 for ; Wed, 22 Apr 2020 04:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8286E206EC for ; Wed, 22 Apr 2020 04:06:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="YIzK+alY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbgDVEGO (ORCPT ); Wed, 22 Apr 2020 00:06:14 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:59108 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbgDVEGO (ORCPT ); Wed, 22 Apr 2020 00:06:14 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03M3wTSX086199; Wed, 22 Apr 2020 04:05:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=0/577IYdzaOZI8ebekA2HHPBCL9rJ5Gyj91H7FB//oA=; b=YIzK+alYeGi7+Y26Ho0Slm3m4QWJOD3IpC2P7zqdz7SADiujSbjqaVk9n+SxT5XzWYdt 0oz83ZaSS5DftkRMe4wEgZDdbV+BYMPImkH7ECg5CBgDKbdwiVU8g217Mr4qxd9qTMEP FiBcE3XeD3MCbYkK1H3jxIFRxMDZLJfnTCRjR2cJX04uZUvL8JmtDGC6OV7T9/fSa5nD GrXauZTR7KFhUCRBcqT/CaYDk8uY7jmjB61plOUkq+NGeDX/ojy7wevmw6hIhDUXQumR SqCJG0O9ehN2LyWWqImk/2ZgygnOGVorOmaXMoKwjv/SnKSFXvOAlwEodkjMRtJOr2LC aQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 30fsgm0bnu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Apr 2020 04:05:52 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03M3wFak152472; Wed, 22 Apr 2020 04:05:52 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 30gb1hhrss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Apr 2020 04:05:52 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 03M45mFS029889; Wed, 22 Apr 2020 04:05:48 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Apr 2020 21:05:48 -0700 To: Jason Yan Cc: , , , , , , Hulk Robot Subject: Re: [PATCH] scsi: st: remove unneeded variable 'result' in st_release() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200418070605.11450-1-yanaijie@huawei.com> Date: Wed, 22 Apr 2020 00:05:45 -0400 In-Reply-To: <20200418070605.11450-1-yanaijie@huawei.com> (Jason Yan's message of "Sat, 18 Apr 2020 15:06:05 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9598 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004220030 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9598 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 clxscore=1011 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004220030 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason, > Also remove a strange '^L' after this function. > > Fix the following coccicheck warning: > > drivers/scsi/st.c:1460:5-11: Unneeded variable: "result". Return "0" on > line 1473 Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering