public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "wubo \(T\)" <wubo40@huawei.com>
Cc: "lduncan\@suse.com" <lduncan@suse.com>,
	"cleech\@redhat.com" <cleech@redhat.com>,
	"jejb\@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
	"open-iscsi\@googlegroups.com" <open-iscsi@googlegroups.com>,
	"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>,
	Mingfangsen <mingfangsen@huawei.com>,
	"liuzhiqiang \(I\)" <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH v3] scsi: avoid potential deadloop in iscsi_if_rx func
Date: Tue, 12 Nov 2019 20:37:05 -0500	[thread overview]
Message-ID: <yq18soksgji.fsf@oracle.com> (raw)
In-Reply-To: <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFB0ED@dggeml505-mbs.china.huawei.com> (wubo's message of "Thu, 31 Oct 2019 06:17:01 +0000")


> In iscsi_if_rx func, after receiving one request through
> iscsi_if_recv_msg func, iscsi_if_send_reply will be called to try to
> reply the request in do-loop. If the return of iscsi_if_send_reply
> func return -EAGAIN all the time, one deadloop will occur.
>  
> For example, a client only send msg without calling recvmsg func, 
> then it will result in the watchdog soft lockup. 
> The details are given as follows,

Lee/Chris/Ulrich: Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2019-11-13  1:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  6:17 [PATCH v3] scsi: avoid potential deadloop in iscsi_if_rx func wubo (T)
2019-11-06  1:08 ` Zhiqiang Liu
2019-11-13  1:37 ` Martin K. Petersen [this message]
2019-11-13  3:29   ` Lee Duncan
2019-11-13 17:52   ` Lee Duncan
  -- strict thread matches above, loose matches on Subject: below --
2019-11-14 12:46 wubo (T)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq18soksgji.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=Ulrich.Windl@rz.uni-regensburg.de \
    --cc=cleech@redhat.com \
    --cc=jejb@linux.ibm.com \
    --cc=lduncan@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=mingfangsen@huawei.com \
    --cc=open-iscsi@googlegroups.com \
    --cc=wubo40@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox