From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Laura Abbott <labbott@redhat.com>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.com>,
Mike Christie <mchristi@redhat.com>,
Maurizio Lombardi <mlombard@redhat.com>,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] iscsi-target: Don't use stack buffer for scatterlist
Date: Thu, 30 Aug 2018 07:19:10 -0400 [thread overview]
Message-ID: <yq18t4o5cgh.fsf@oracle.com> (raw)
In-Reply-To: <20180823203626.15108-1-labbott@redhat.com> (Laura Abbott's message of "Thu, 23 Aug 2018 13:36:26 -0700")
> Fedora got a bug report of a crash with iSCSI:
>
> kernel BUG at include/linux/scatterlist.h:143!
> ...
> RIP: 0010:iscsit_do_crypto_hash_buf+0x154/0x180 [iscsi_target_mod]
> ...
> Call Trace:
> ? iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod]
> iscsit_get_rx_pdu+0x4cd/0xa90 [iscsi_target_mod]
> ? native_sched_clock+0x3e/0xa0
> ? iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod]
> iscsi_target_rx_thread+0x81/0xf0 [iscsi_target_mod]
> kthread+0x120/0x140
> ? kthread_create_worker_on_cpu+0x70/0x70
> ret_from_fork+0x3a/0x50
>
> This is a BUG_ON for using a stack buffer with a scatterlist. There
> are two cases that trigger this bug. Switch to using a dynamically
> allocated buffer for one case and do not assign a NULL buffer in
> another case.
Mike: Please review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-08-30 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 20:36 [PATCHv2] iscsi-target: Don't use stack buffer for scatterlist Laura Abbott
2018-08-30 11:19 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18t4o5cgh.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=mlombard@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox