From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7CEC43142 for ; Thu, 2 Aug 2018 20:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89AF121566 for ; Thu, 2 Aug 2018 20:22:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="zvIsZW0t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89AF121566 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730730AbeHBWPW (ORCPT ); Thu, 2 Aug 2018 18:15:22 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:35090 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbeHBWPW (ORCPT ); Thu, 2 Aug 2018 18:15:22 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w72KJex0190826; Thu, 2 Aug 2018 20:21:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=C68rdPil5Nk81eSFc0SzX53G5W8c3byTHTeK7bQBPt8=; b=zvIsZW0tUs4wEiL5AQ8ZR0dY6gHd8CtZtVBYovWVVVyFpwSXW413UkEptzhtagY+w978 u7xXjXwvw5wCs9AWLcqzjoG8AyaiK0qiUSJpXjFgBWBIqoHkppqt0nXKcOzyYobf/bPj g4Y+tZjLGXtGHKdkyRG/6zptr5Bm4bNO8o28+7ZzczIZIwW7Jv0T33ajPx8wON70Ik8Q kQMcPH1vf9FE9/bLCZNfk7zvL82zvjoQfU1bq/by9S1LFCPu1AkiJimEUvxWPSqdptDG OIgIh1QXXfYvWjjAS1ChKUVfqWvVXFzBtsfEUJa9tyFv437qhOuNtU68Mmt0+tto/iGI xA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2km6j3rkn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Aug 2018 20:21:39 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w72KLcxU003658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Aug 2018 20:21:38 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w72KLXfZ025080; Thu, 2 Aug 2018 20:21:34 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Aug 2018 13:21:33 -0700 To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180731195155.46664-1-keescook@chromium.org> Date: Thu, 02 Aug 2018 16:21:28 -0400 In-Reply-To: <20180731195155.46664-1-keescook@chromium.org> (Kees Cook's message of "Tue, 31 Jul 2018 12:51:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8973 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=530 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808020200 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, > This is a follow-up to commit f7068114d45e ("sr: pass down correctly > sized SCSI sense buffer") which further cleans up and removes needless > sense character array buffers and "struct request_sense" usage in favor > of the common "struct scsi_sense_hdr". This looks good to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering