From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Stephen Kitt <steve@sk2.org>
Cc: hare@suse.com, linux-scsi@vger.kernel.org,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bfa: remove VLA
Date: Thu, 15 Mar 2018 00:37:20 -0400 [thread overview]
Message-ID: <yq18tau7y4f.fsf@oracle.com> (raw)
In-Reply-To: <20180308213841.13807-1-steve@sk2.org> (Stephen Kitt's message of "Thu, 8 Mar 2018 22:38:41 +0100")
Stephen,
> bfad_bsg.c uses a variable-length array declaration to measure the
> size of a putative array; this can be replaced by the product of the
> size of an element and the number of elements, avoiding the VLA
> altogether.
>
> - sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {
> + sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) {
These parentheses made me blurry eyed but it's actually OK.
Applied to 4.17/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-03-15 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 21:38 [PATCH] bfa: remove VLA Stephen Kitt
2018-03-08 21:43 ` Kees Cook
2018-03-09 22:15 ` Stephen Kitt
2018-03-15 4:37 ` Martin K. Petersen [this message]
2018-03-15 11:40 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18tau7y4f.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox