From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbeAVUCB (ORCPT ); Mon, 22 Jan 2018 15:02:01 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:34478 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbeAVUB4 (ORCPT ); Mon, 22 Jan 2018 15:01:56 -0500 To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Linux Kernel Mailinglist , Hannes Reinecke , Linux NVMe Mailinglist , "Martin K . Petersen" Subject: Re: [PATCH v4 2/2] nvme: add tracepoint for nvme_complete_rq From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180119141819.11938-1-jthumshirn@suse.de> <20180119141819.11938-3-jthumshirn@suse.de> <20180122152340.GB5818@lst.de> <20180122153040.2myfgm7hvjtd5n3d@linux-x5ow.site> Date: Mon, 22 Jan 2018 14:35:23 -0500 In-Reply-To: <20180122153040.2myfgm7hvjtd5n3d@linux-x5ow.site> (Johannes Thumshirn's message of "Mon, 22 Jan 2018 16:30:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8782 signatures=668655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=504 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801220272 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes, > On Mon, Jan 22, 2018 at 04:23:40PM +0100, Christoph Hellwig wrote: >> Wouldn't some indication on which queue this completion happens >> be useful? > > Probably yes. I'll add it in v5. Yes, that would be great. I always end up having to use custom printks for this. -- Martin K. Petersen Oracle Linux Engineering