From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Shuah Khan <shuah@kernel.org>,
linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stanley Zhang <stazhang@purestorage.com>,
Uday Shankar <ushankar@purestorage.com>
Subject: Re: [PATCH v2 01/19] blk-integrity: take const pointer in blk_integrity_rq()
Date: Sun, 04 Jan 2026 16:50:00 -0500 [thread overview]
Message-ID: <yq1a4ytt5du.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260103004529.1582405-2-csander@purestorage.com> (Caleb Sander Mateos's message of "Fri, 2 Jan 2026 17:45:11 -0700")
Caleb,
> blk_integrity_rq() doesn't modify the struct request passed in, so allow
> a const pointer to be passed. Use a matching signature for the
> !CONFIG_BLK_DEV_INTEGRITY version.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2026-01-04 21:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 0:45 [PATCH v2 00/19] ublk: add support for integrity data Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 01/19] blk-integrity: take const pointer in blk_integrity_rq() Caleb Sander Mateos
2026-01-04 21:50 ` Martin K. Petersen [this message]
2026-01-03 0:45 ` [PATCH v2 02/19] ublk: move ublk flag check functions earlier Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 03/19] ublk: support UBLK_PARAM_TYPE_INTEGRITY in device creation Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 04/19] ublk: set request integrity params in ublksrv_io_desc Caleb Sander Mateos
2026-01-03 14:14 ` Ming Lei
2026-01-05 16:44 ` Caleb Sander Mateos
2026-01-06 1:55 ` Ming Lei
2026-01-07 17:45 ` Caleb Sander Mateos
2026-01-08 2:03 ` Ming Lei
2026-01-03 0:45 ` [PATCH v2 05/19] ublk: add ublk_copy_user_bvec() helper Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 06/19] ublk: split out ublk_user_copy() helper Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 07/19] ublk: inline ublk_check_and_get_req() into ublk_user_copy() Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 08/19] ublk: move offset check out of __ublk_check_and_get_req() Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 09/19] ublk: implement integrity user copy Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 10/19] ublk: support UBLK_F_INTEGRITY Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 11/19] ublk: optimize ublk_user_copy() on daemon task Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 12/19] selftests: ublk: display UBLK_F_INTEGRITY support Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 13/19] selftests: ublk: add utility to get block device metadata size Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 14/19] selftests: ublk: add kublk support for integrity params Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 15/19] selftests: ublk: implement integrity user copy in kublk Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 16/19] selftests: ublk: support non-O_DIRECT backing files Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 17/19] selftests: ublk: add integrity data support to loop target Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 18/19] selftests: ublk: add integrity params test Caleb Sander Mateos
2026-01-03 0:45 ` [PATCH v2 19/19] selftests: ublk: add end-to-end integrity test Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a4ytt5du.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shuah@kernel.org \
--cc=stazhang@purestorage.com \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox