Re: [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs_bsg

Bean Huo
2023-01-06T14:47:53Z

Hi Bart,

Thanks for your report, I will fix it along with cleanup patch. Sorry
for this issue!!

Kind regards,

Bean

On 05.01.23 11:37 PM, Bart Van Assche wrote:
> Hi Bean,
>
> I think this patch is the first patch that adds a declaration in
> ufshcd.h that uses the enum dma_data_direction data type. That leads
> to the following compiler warning:
>
> In file included from drivers/ufs/host/tc-dwc-g210-pci.c:10:
> ./include/ufs/ufshcd.h:1282:72: warning: ‘enum dma_data_direction’
> declared inside parameter list will not be visible outside of this
> definition or declaration
>  1282 |                                      struct scatterlist
> *sg_list, enum dma_data_direction dir);
>       |        ^~~~~~~~~~~~~~~~~~
>
> Can you please post a patch to fix this? Adding the following line is
> probably sufficient:
>
> #include <linux/dma-direction.h>
>
> This has been detected with the following script:
> https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers
>
>
> Thanks,
>
> Bart.