From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A90F1CA9EC7 for ; Tue, 5 Nov 2019 05:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BC5C2084D for ; Tue, 5 Nov 2019 05:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GFPNs2xU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730439AbfKEFWm (ORCPT ); Tue, 5 Nov 2019 00:22:42 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:51448 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfKEFWm (ORCPT ); Tue, 5 Nov 2019 00:22:42 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA55KJDF091759; Tue, 5 Nov 2019 05:22:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=bNZ1zutnBi2cMRzH04JNk7iED2JIZauTaeUKBWAxtCA=; b=GFPNs2xUsXONyEFfx4uTZ5EmWKEIsRXAPcz3/s+JJfluxJiYS3tiZJxbn3c+3NZE3AjR qaCospvS+yjoWzj316zsBREnaz4nArY6Ml02Aw7z80uOkbJss4lY/6OZc0fE3wQLLylW FuKnSaZoTJvfjCahpF1xB518+L/cHE9Ct1f3vPEgjEWnxX66SR9VBnXMNnegZk6CBPxV PBYB0LXn6kkSFXDPShTDzlcrYX0t4+adOaOcKi8okmnwpoLFs3Q01ngSht9uab/rFJpW Y2P9PBMjerQHcPD+o1MIWkVyD5PDvsOm6n9JYoZItrfhD5RdSrqxN+TakVja6aPTowkn MA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2w12er3fmt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 05:22:17 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA553SXd123977; Tue, 5 Nov 2019 05:22:16 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2w1kxnmf4v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 05:22:16 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA55MFp1022758; Tue, 5 Nov 2019 05:22:15 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Nov 2019 21:22:15 -0800 To: Pan Bian Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] scsi: fnic: fix use after free From: "Martin K. Petersen" Organization: Oracle Corporation References: <1572881182-37664-1-git-send-email-bianpan2016@163.com> Date: Tue, 05 Nov 2019 00:22:12 -0500 In-Reply-To: <1572881182-37664-1-git-send-email-bianpan2016@163.com> (Pan Bian's message of "Mon, 4 Nov 2019 23:26:22 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=621 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050040 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=723 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050041 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pan, > The memory chunk io_req is released by mempool_free. Accessing > io_req->start_time will result in a use after free bug. The variable > start_time is a backup of the timestamp. So, use start_time here to > avoid use after free. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering