From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A249C43381 for ; Thu, 21 Mar 2019 00:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62BF0218AE for ; Thu, 21 Mar 2019 00:11:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Ow6X2Oz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727660AbfCUALM (ORCPT ); Wed, 20 Mar 2019 20:11:12 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:57920 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726914AbfCUALL (ORCPT ); Wed, 20 Mar 2019 20:11:11 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2KNraq9151111; Thu, 21 Mar 2019 00:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=MUUUrU9PxP9jY48hBhr+UlpQkYMWTNfEwILAjAppAL0=; b=Ow6X2Oz7Vztjw5jkzzS/KVaDMoPobNsi/UWpwzvxuVloDxHqEO00+DG14S7R15iLKqcy auQya1qm8zJUIUc83KwkIMRVCDru+fkbqGAb16poSoC62CsqekIrSva3AFdeww+KXC8v NJI1qiUJ/Z2H5j7OASlkt0x9Wdwn8j8JM1tgXHtn9jljCHFzzfZgT3V+RP+BvwfLyB3P oKif5dXx13ftw2emB3C6lDlknQwiavlWe1UY9k88nlRPHfY2RPJ9wUFH0OVrdJC/oLHP DIbUwJgxOC6/N5DCeKA+l6Mo8bP5uFDUZNKyZDZAxXuaOW0HC23uTV+O9xDTqDvTFg3B VA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2r8pnex0q5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 00:10:49 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2L0Ahnp022370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 00:10:43 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2L0Af9b004135; Thu, 21 Mar 2019 00:10:41 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Mar 2019 17:10:41 -0700 To: Nathan Chancellor Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Matthias Brugger , Alim Akhtar , Avri Altman , Pedro Sousa , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, clang-built-linux@googlegroups.com, Nick Desaulniers Subject: Re: [PATCH] scsi: ufs-mediatek: Avoid using ret uninitialized in ufs_mtk_setup_clocks From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190320180340.25795-1-natechancellor@gmail.com> Date: Wed, 20 Mar 2019 20:10:38 -0400 In-Reply-To: <20190320180340.25795-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Wed, 20 Mar 2019 11:03:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9201 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=745 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903200170 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan, > Remove the default case and initialize ret to -EINVAL to properly fix > this warning. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering