From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5A7C282CA for ; Wed, 13 Feb 2019 03:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58A742190A for ; Wed, 13 Feb 2019 03:02:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OSfAKwMw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390335AbfBMDCM (ORCPT ); Tue, 12 Feb 2019 22:02:12 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55258 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728440AbfBMDCF (ORCPT ); Tue, 12 Feb 2019 22:02:05 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1D2wao2040802; Wed, 13 Feb 2019 03:01:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=SHDxREFjwANVKrlFk5mD/fYvoQO4Sa+mXDAIIolqCTI=; b=OSfAKwMwcBHn9rTjqwcp7HLHo2OBDB0o/Rbk775medm6GcWxLA+Pn7j0FaXLDPXbm/0v JAZbDJKn5NqpRNWuUVdgnPFd0fSWj3PRrr1hZmkGGyn2kyYHoaL1iB8rtittRPbwnGZ0 fhGJ4xVfGab0UL+wrJ8FR+h1FbLkKi8lMHpRoxMo1O40itfjyLstZsg2zixhhhppag72 8AYoyF+Vm/XLV5RyoclZw0CKDt9+NEh0RS6T5xVtL9l76gaIzYxr1cPbliqlHbZWaBcJ 3Nsjjayy94OjUx16b1/jT2K0n3DEwbOzEUh1s/RtMOjMph3jt5p4Zu4jth2dqiCGCS+M wA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2qhrekfgdm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 03:01:50 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1D31oba009980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 03:01:50 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1D31nKs009833; Wed, 13 Feb 2019 03:01:49 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 12 Feb 2019 19:01:49 -0800 To: "chenxiang \(M\)" Cc: "Martin K. Petersen" , John Garry , , , , Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw From: "Martin K. Petersen" Organization: Oracle Corporation References: <1549450376-114929-1-git-send-email-john.garry@huawei.com> <1549450376-114929-2-git-send-email-john.garry@huawei.com> <53c516cc-cce3-a3e1-718f-6fc465b6e401@hisilicon.com> Date: Tue, 12 Feb 2019 22:01:46 -0500 In-Reply-To: <53c516cc-cce3-a3e1-718f-6fc465b6e401@hisilicon.com> (chenxiang's message of "Mon, 11 Feb 2019 19:36:01 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9165 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=908 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902130018 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chenxiang, >>> + if (prot_flags & SCSI_PROT_REF_CHECK) >>> + return T10_CHK_APP_TAG_MSK; >> Polarity is a bit unclear here. Is this statement disabling checking of >> the app tag? > > Yes, disabling checking of app tag. > For here, 1'b0 presents the related byte in DIF will be checked, and > 1'b1 presents the related byte in DIF will not be checked. OK, thanks for the clarification! -- Martin K. Petersen Oracle Linux Engineering