Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw

Martin K. Petersen
2019-02-08T23:14:12Z

John,

Just noticed this while inspecting the resulting complete diff:

> static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
> {
> unsigned char prot_flags = scsi_cmnd->prot_flags;
>
> - if (prot_flags & SCSI_PROT_TRANSFER_PI) {
> - if (prot_flags & SCSI_PROT_REF_CHECK)
> - return 0xc << 16;
> - return 0xfc << 16;
> - }
> - return 0;
> + if (prot_flags & SCSI_PROT_REF_CHECK)
> + return T10_CHK_APP_TAG_MSK;

Polarity is a bit unclear here. Is this statement disabling checking of
the app tag?

> + return T10_CHK_REF_TAG_MSK | T10_CHK_APP_TAG_MSK;
> }

--
Martin K. Petersen Oracle Linux Engineering