Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw

Martin K. Petersen
2019-02-13T03:02:13Z

chenxiang,

>>> + if (prot_flags & SCSI_PROT_REF_CHECK)
>>> + return T10_CHK_APP_TAG_MSK;

>> Polarity is a bit unclear here. Is this statement disabling checking of
>> the app tag?
>
> Yes, disabling checking of app tag.
> For here, 1'b0 presents the related byte in DIF will be checked, and
> 1'b1 presents the related byte in DIF will not be checked.

OK, thanks for the clarification!

--
Martin K. Petersen Oracle Linux Engineering