From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>,
Dave Carroll <David.Carroll@microsemi.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits
Date: Tue, 07 Feb 2017 17:25:51 -0500 [thread overview]
Message-ID: <yq1a89xprio.fsf@oracle.com> (raw)
In-Reply-To: <20170207125948.490095-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 7 Feb 2017 13:59:30 +0100")
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> Shifting a dma_addr_t right by 32 bits causes a compile-time
Arnd> warning when that type is only 32 bit wide:
Arnd> drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter':
Arnd> drivers/scsi/aacraid/src.c:414:29: error: right shift count >=
Arnd> width of type [-Werror=shift-count-overflow]
Arnd> This changes the driver to use the predefined macros consistently,
Arnd> including one correct but open-coded upper_32_bits() instance.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-02-07 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 12:59 [PATCH] scsi: aacraid: avoid open-coded upper_32_bits Arnd Bergmann
2017-02-07 13:05 ` Johannes Thumshirn
2017-02-07 19:37 ` Raghava Aditya Renukunta
2017-02-07 22:25 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a89xprio.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=David.Carroll@microsemi.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=aacraid@microsemi.com \
--cc=arnd@arndb.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox