From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbdBGXog (ORCPT ); Tue, 7 Feb 2017 18:44:36 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:47929 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdBGXof (ORCPT ); Tue, 7 Feb 2017 18:44:35 -0500 To: Arnd Bergmann Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , Johannes Thumshirn , Raghava Aditya Renukunta , Dave Carroll , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170207125948.490095-1-arnd@arndb.de> Date: Tue, 07 Feb 2017 17:25:51 -0500 In-Reply-To: <20170207125948.490095-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 7 Feb 2017 13:59:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Arnd" == Arnd Bergmann writes: Arnd> Shifting a dma_addr_t right by 32 bits causes a compile-time Arnd> warning when that type is only 32 bit wide: Arnd> drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': Arnd> drivers/scsi/aacraid/src.c:414:29: error: right shift count >= Arnd> width of type [-Werror=shift-count-overflow] Arnd> This changes the driver to use the predefined macros consistently, Arnd> including one correct but open-coded upper_32_bits() instance. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering