* [PATCH] [SCSI] ipr: use kobj_to_dev()
@ 2022-05-10 10:51 cgel.zte
2022-05-11 20:54 ` Brian King
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: cgel.zte @ 2022-05-10 10:51 UTC (permalink / raw)
To: brking
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, Minghao Chi,
Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Use kobj_to_dev() instead of open-coding it.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/scsi/ipr.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 353cf47db79c..256ec6d08c16 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -3456,7 +3456,7 @@ static ssize_t ipr_read_trace(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(dev);
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
unsigned long lock_flags = 0;
@@ -4182,7 +4182,7 @@ static ssize_t ipr_read_async_err_log(struct file *filep, struct kobject *kobj,
struct bin_attribute *bin_attr, char *buf,
loff_t off, size_t count)
{
- struct device *cdev = container_of(kobj, struct device, kobj);
+ struct device *cdev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(cdev);
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
struct ipr_hostrcb *hostrcb;
@@ -4206,7 +4206,7 @@ static ssize_t ipr_next_async_err_log(struct file *filep, struct kobject *kobj,
struct bin_attribute *bin_attr, char *buf,
loff_t off, size_t count)
{
- struct device *cdev = container_of(kobj, struct device, kobj);
+ struct device *cdev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(cdev);
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
struct ipr_hostrcb *hostrcb;
@@ -4267,7 +4267,7 @@ static ssize_t ipr_read_dump(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *cdev = container_of(kobj, struct device, kobj);
+ struct device *cdev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(cdev);
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
struct ipr_dump *dump;
@@ -4456,7 +4456,7 @@ static ssize_t ipr_write_dump(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *cdev = container_of(kobj, struct device, kobj);
+ struct device *cdev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(cdev);
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
int rc;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] ipr: use kobj_to_dev()
2022-05-10 10:51 [PATCH] [SCSI] ipr: use kobj_to_dev() cgel.zte
@ 2022-05-11 20:54 ` Brian King
2022-05-17 1:32 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Brian King @ 2022-05-11 20:54 UTC (permalink / raw)
To: cgel.zte, brking
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, Minghao Chi,
Zeal Robot
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] ipr: use kobj_to_dev()
2022-05-10 10:51 [PATCH] [SCSI] ipr: use kobj_to_dev() cgel.zte
2022-05-11 20:54 ` Brian King
@ 2022-05-17 1:32 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-05-17 1:32 UTC (permalink / raw)
To: cgel.zte
Cc: brking, jejb, martin.petersen, linux-scsi, linux-kernel,
Minghao Chi, Zeal Robot
> Use kobj_to_dev() instead of open-coding it.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] ipr: use kobj_to_dev()
2022-05-10 10:51 [PATCH] [SCSI] ipr: use kobj_to_dev() cgel.zte
2022-05-11 20:54 ` Brian King
2022-05-17 1:32 ` Martin K. Petersen
@ 2022-05-20 1:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-05-20 1:09 UTC (permalink / raw)
To: cgel.zte, brking
Cc: Martin K . Petersen, linux-scsi, jejb, Zeal Robot, linux-kernel,
Minghao Chi
On Tue, 10 May 2022 10:51:13 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Use kobj_to_dev() instead of open-coding it.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] ipr: use kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/aabd5fea4946
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-20 1:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-10 10:51 [PATCH] [SCSI] ipr: use kobj_to_dev() cgel.zte
2022-05-11 20:54 ` Brian King
2022-05-17 1:32 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox