From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbdDTCSA (ORCPT ); Wed, 19 Apr 2017 22:18:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18144 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766014AbdDTCR6 (ORCPT ); Wed, 19 Apr 2017 22:17:58 -0400 To: Colin King Cc: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [SCSI] aic7xxx: fix order of arguments in function prototype From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170408172842.20226-1-colin.king@canonical.com> Date: Wed, 19 Apr 2017 22:17:46 -0400 In-Reply-To: <20170408172842.20226-1-colin.king@canonical.com> (Colin King's message of "Sat, 8 Apr 2017 18:28:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > The vendor/device and subvendor/subdevice arguments to the function > prototype ahc_9005_subdevinfo_valid are in the wrong order and need to > be swapped to fix this. Detected with PVS-Studio studio. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering