From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chris Friesen <chris.friesen@windriver.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: absurdly high "optimal_io_size" on Seagate SAS disk
Date: Fri, 07 Nov 2014 11:25:25 -0500 [thread overview]
Message-ID: <yq1bnoj9dvu.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <545C5A1B.9020206@windriver.com> (Chris Friesen's message of "Thu, 6 Nov 2014 23:35:23 -0600")
>>>>> "Chris" == Chris Friesen <chris.friesen@windriver.com> writes:
Chris,
Chris> Also, I think it's wrong for filesystems and userspace to use it
Chris> for alignment. In E.4 and E.5 in the "sbc3r25.pdf" doc, it looks
Chris> like they use the optimal granularity field for alignment, not
Chris> the optimal transfer length.
The original rationale behind the OTLG and OTL values was to be able to
express stripe chunk size and stripe width. And to encourage aligned,
full stripe writes but nothing bigger than that. Obviously the wording
went through the usual standards body process to be vague/generic enough
to be used for anything. It has changed several times since sbc3r25,
btw.
The kernel really isn't using io_opt. The value is merely stacked and
communicated to userspace. The reason the partitioning tools blow up
with weird values is that they try to align partitions beginnings to the
stripe width. Which is the right thing to do as far as I'm concerned.
I have worked with many, many partners in the storage industry to make
sure they report sensible values in the Block Limits VPD. I have no
reason to believe that the SAS drive issue in question is anything but a
simple typo. I know there was a bug open with Seagate. I assume it has
been fixed in their latest firmware. To my knowledge it is not a problem
in any of their other drive models. Certainly isn't in any of the ones
we are shipping.
The unfortunate thing with disk drives is that firmware updates are much
harder to deal with. And you rarely end up having access to an updated
firmware unless your drive was procured through a vendor like Dell, HP
or Oracle. That's why I originally opted to quirk this model in
Linux. Otherwise I would just have said "update your firmware".
If we had devices from many different vendors showing up with values
that constantly threw off our tooling I would have more reason to be
concerned. But we haven't. And this code has been in the kernel since
2.6.32 or so.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-11-07 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 16:47 absurdly high "optimal_io_size" on Seagate SAS disk Chris Friesen
2014-11-06 17:16 ` Chris Friesen
2014-11-06 17:34 ` Martin K. Petersen
2014-11-06 17:45 ` Chris Friesen
2014-11-06 18:12 ` Martin K. Petersen
2014-11-06 18:15 ` Jens Axboe
2014-11-06 19:14 ` Chris Friesen
2014-11-07 1:56 ` Martin K. Petersen
2014-11-07 5:35 ` Chris Friesen
2014-11-07 15:18 ` Dale R. Worley
2014-11-07 16:25 ` Martin K. Petersen [this message]
2014-11-07 17:42 ` Martin K. Petersen
2014-11-07 17:51 ` Chris Friesen
2014-11-07 18:03 ` Martin K. Petersen
2014-11-07 18:48 ` Chris Friesen
2014-11-07 19:17 ` Martin K. Petersen
2014-11-07 21:04 ` Chris Friesen
2014-11-07 17:10 ` Elliott, Robert (Server Storage)
2014-11-07 17:40 ` Martin K. Petersen
2014-11-07 20:15 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bnoj9dvu.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=chris.friesen@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).