From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinicke <hare@suse.de>,
Finn Thain <fthain@telegraphics.com.au>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB
Date: Tue, 05 Sep 2017 08:24:40 -0400 [thread overview]
Message-ID: <yq1d175s587.fsf@oracle.com> (raw)
In-Reply-To: <20170905074956.469733-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 5 Sep 2017 09:49:23 +0200")
Arnd,
> Without CONFIG_BLK_DEV_BSGLIB, we get a link error here:
>
> drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize':
> scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue'
> scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue'
> drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch':
> scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done'
>
> This modifies the Kconfig 'select' statement accordingly, and matching
> what we do for the other two scsi_transport implementations that use
> bsglib.
>
> Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-09-05 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 7:49 [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Arnd Bergmann
2017-09-05 11:20 ` Christoph Hellwig
2017-09-05 12:24 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d175s587.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=arnd@arndb.de \
--cc=fthain@telegraphics.com.au \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox