From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbdHODHc (ORCPT ); Mon, 14 Aug 2017 23:07:32 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37330 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbdHODHa (ORCPT ); Mon, 14 Aug 2017 23:07:30 -0400 To: Helge Deller Cc: linux-scsi@vger.kernel.org, James Bottomley , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Subject: Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762 From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170810190849.GA12659@p100.box> Date: Mon, 14 Aug 2017 23:07:20 -0400 In-Reply-To: <20170810190849.GA12659@p100.box> (Helge Deller's message of "Thu, 10 Aug 2017 21:08:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Helge, > On parisc I see this UBSAN warning with a sym53c896: > > UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24 > index -1903078336 is out of range for type 'u32 [7]' > > Avoid this warning by switching to dev64_ul(). Applied to 4.14/scsi-queue. Thank you, Helge! -- Martin K. Petersen Oracle Linux Engineering