From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbcA0CeA (ORCPT ); Tue, 26 Jan 2016 21:34:00 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:41238 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbcA0Cd6 (ORCPT ); Tue, 26 Jan 2016 21:33:58 -0500 To: Johannes Thumshirn Cc: "Martin K . Petersen" , James Bottomley , James Smart , Dick Kennedy , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl From: "Martin K. Petersen" Organization: Oracle Corporation References: <1453302520-10499-1-git-send-email-jthumshirn@suse.de> Date: Tue, 26 Jan 2016 21:33:43 -0500 In-Reply-To: <1453302520-10499-1-git-send-email-jthumshirn@suse.de> (Johannes Thumshirn's message of "Wed, 20 Jan 2016 16:08:40 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Johannes" == Johannes Thumshirn writes: Johannes> This removes a redundant code block that will either be Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in Johannes> phba->cfg_poll or not. The code is just duplicated in both Johannes> cases, hence we unify it again. Johannes> This probably is a left over from some sort of refactoring. James/Dick: Please review. -- Martin K. Petersen Oracle Linux Engineering