From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Li Feng <fengli@smartx.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-kernel@vger.kernel.org (open list),
linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM),
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2] scsi: sd: Keep the discard mode stable
Date: Wed, 26 Jun 2024 22:43:46 -0400 [thread overview]
Message-ID: <yq1ed8jglom.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240619071412.140100-1-fengli@smartx.com> (Li Feng's message of "Wed, 19 Jun 2024 15:14:03 +0800")
Li,
> The discard mode has been negotiated during the SCSI probe. If the
> mode is temporarily changed from UNMAP to WRITE SAME with UNMAP, IO
> ERROR may occur because the target may not implement WRITE SAME with
> UNMAP. Keep the discard mode stable to fix this issue.
This is fine with me. It's a subset of what I have pending in my
discovery series but it doesn't look like that will ready in time for
6.11. So let's just grab this for now.
Jens: Probably easiest if you take this through the block-limits branch.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-06-27 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 7:14 [PATCH v2] scsi: sd: Keep the discard mode stable Li Feng
2024-06-19 7:16 ` Christoph Hellwig
2024-06-27 2:43 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ed8jglom.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=fengli@smartx.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox