* [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable()
[not found] <CGME20221028073553epcms2p6dc4f8bdbebdc8f96f43fc4197b3edd0c@epcms2p6>
@ 2022-10-28 7:35 ` Keoseong Park
2022-10-28 22:37 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Keoseong Park @ 2022-10-28 7:35 UTC (permalink / raw)
To: ALIM AKHTAR, avri.altman@wdc.com, bvanassche@acm.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
beanhuo@micron.com, adrian.hunter@intel.com, Jinyoung CHOI,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Use "if error return" style in ufshcd_hba_enable().
No functional change.
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
drivers/ufs/core/ufshcd.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index b2203dd79e8c..4288241040db 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -4665,14 +4665,18 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
/* enable UIC related interrupts */
ufshcd_enable_intr(hba, UFSHCD_UIC_MASK);
ret = ufshcd_dme_reset(hba);
- if (!ret) {
- ret = ufshcd_dme_enable(hba);
- if (!ret)
- ufshcd_vops_hce_enable_notify(hba, POST_CHANGE);
- if (ret)
- dev_err(hba->dev,
- "Host controller enable failed with non-hce\n");
+ if (ret) {
+ dev_err(hba->dev, "DME_RESET failed\n");
+ return ret;
}
+
+ ret = ufshcd_dme_enable(hba);
+ if (ret) {
+ dev_err(hba->dev, "Enabling DME failed\n");
+ return ret;
+ }
+
+ ufshcd_vops_hce_enable_notify(hba, POST_CHANGE);
} else {
ret = ufshcd_hba_execute_hce(hba);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable()
2022-10-28 7:35 ` [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable() Keoseong Park
@ 2022-10-28 22:37 ` Bart Van Assche
2022-11-08 2:56 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2022-10-28 22:37 UTC (permalink / raw)
To: keosung.park, ALIM AKHTAR, avri.altman@wdc.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
beanhuo@micron.com, adrian.hunter@intel.com, Jinyoung CHOI,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
On 10/28/22 00:35, Keoseong Park wrote:
> Use "if error return" style in ufshcd_hba_enable().
> No functional change.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable()
2022-10-28 7:35 ` [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable() Keoseong Park
2022-10-28 22:37 ` Bart Van Assche
@ 2022-11-08 2:56 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-11-08 2:56 UTC (permalink / raw)
To: Keoseong Park
Cc: ALIM AKHTAR, avri.altman@wdc.com, bvanassche@acm.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
beanhuo@micron.com, adrian.hunter@intel.com, Jinyoung CHOI,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Keoseong,
> Use "if error return" style in ufshcd_hba_enable(). No functional
> change.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable()
2022-10-28 7:35 ` [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable() Keoseong Park
2022-10-28 22:37 ` Bart Van Assche
2022-11-08 2:56 ` Martin K. Petersen
@ 2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-11-17 18:29 UTC (permalink / raw)
To: adrian.hunter, bvanassche, Keoseong Park, linux-kernel, beanhuo,
linux-scsi, avri.altman, ALIM AKHTAR, jejb, Jinyoung CHOI
Cc: Martin K . Petersen
On Fri, 28 Oct 2022 16:35:53 +0900, Keoseong Park wrote:
> Use "if error return" style in ufshcd_hba_enable().
> No functional change.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: ufs: core: Refactor ufshcd_hba_enable()
https://git.kernel.org/mkp/scsi/c/bc77fb9ce40c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-17 18:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20221028073553epcms2p6dc4f8bdbebdc8f96f43fc4197b3edd0c@epcms2p6>
2022-10-28 7:35 ` [PATCH] scsi: ufs: core: Refactor ufshcd_hba_enable() Keoseong Park
2022-10-28 22:37 ` Bart Van Assche
2022-11-08 2:56 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox