From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int
Date: Tue, 07 Feb 2017 17:23:24 -0500 [thread overview]
Message-ID: <yq1efz9prmr.fsf@oracle.com> (raw)
In-Reply-To: <20170207115129.18948-1-colin.king@canonical.com> (Colin King's message of "Tue, 7 Feb 2017 11:51:29 +0000")
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin> aac_fib_send can return -ve error returns and hence rcode should
Colin> be signed. Currently the rcode >= 0 check is always true and -ve
Colin> errors are not being checked.
Colin> Thanks to Dan Carpenter for spotting my original broken fix to
Colin> this issue.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-02-07 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 11:51 [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int Colin King
2017-02-07 19:35 ` Raghava Aditya Renukunta
2017-02-07 22:23 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1efz9prmr.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox