From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932529AbdBGWXg (ORCPT ); Tue, 7 Feb 2017 17:23:36 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:51379 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755537AbdBGWXf (ORCPT ); Tue, 7 Feb 2017 17:23:35 -0500 To: Colin King Cc: Adaptec OEM Raid Solutions , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170207115129.18948-1-colin.king@canonical.com> Date: Tue, 07 Feb 2017 17:23:24 -0500 In-Reply-To: <20170207115129.18948-1-colin.king@canonical.com> (Colin King's message of "Tue, 7 Feb 2017 11:51:29 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Colin" == Colin King writes: Colin> aac_fib_send can return -ve error returns and hence rcode should Colin> be signed. Currently the rcode >= 0 check is always true and -ve Colin> errors are not being checked. Colin> Thanks to Dan Carpenter for spotting my original broken fix to Colin> this issue. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering