From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: dgilbert@interlog.com
Cc: Christoph Hellwig <hch@infradead.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 3/3] target/iblock: Add WRITE_SAME w/ UNMAP=0 emulation support
Date: Thu, 15 Nov 2012 10:25:32 -0500 [thread overview]
Message-ID: <yq1ehju28ib.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <50A5043E.1030301@interlog.com> (Douglas Gilbert's message of "Thu, 15 Nov 2012 10:03:26 -0500")
>>>>> "Doug" == Douglas Gilbert <dgilbert@interlog.com> writes:
Doug> On 12-11-15 06:04 AM, Christoph Hellwig wrote:
>>> + /*
>>> + * Enable WRITE_SAME emulation for IBLOCK, use scsi_debug.c default
>>> + */
>>
>> Why would we care what scsi_debug.c uses?
Doug> Would you prefer no hint of where the magic number came from? At
Doug> least somebody who cares when they see that comment might contact
Doug> Martin Petersen and ask why he chose that value.
And the answer is that WRITE SAME(10) takes a two-byte block count.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2012-11-15 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 20:07 [PATCH 0/3] target/iblock: Add WRITE_SAME w/ UNMAP=0 emulation Nicholas A. Bellinger
2012-11-08 20:07 ` [PATCH 1/3] target/sbc: Make WRITE_SAME check differentiate between UNMAP=[1,0] Nicholas A. Bellinger
2012-11-15 10:52 ` Christoph Hellwig
2012-11-08 20:07 ` [PATCH 2/3] target: Add max_write_same_len device attribute Nicholas A. Bellinger
2012-11-15 10:53 ` Christoph Hellwig
2012-11-15 19:23 ` Nicholas A. Bellinger
2012-11-16 13:05 ` Paolo Bonzini
2012-11-08 20:07 ` [PATCH 3/3] target/iblock: Add WRITE_SAME w/ UNMAP=0 emulation support Nicholas A. Bellinger
2012-11-15 11:04 ` Christoph Hellwig
2012-11-15 15:03 ` Douglas Gilbert
2012-11-15 15:25 ` Martin K. Petersen [this message]
2012-11-15 19:29 ` Nicholas A. Bellinger
2012-11-15 19:32 ` Christoph Hellwig
2012-11-15 20:01 ` Elliott, Robert (Server Storage)
2012-11-15 20:31 ` Nicholas A. Bellinger
2012-11-19 11:38 ` Paolo Bonzini
2012-11-19 23:19 ` Elliott, Robert (Server Storage)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ehju28ib.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dgilbert@interlog.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox