From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Yihang Li <liyihang9@h-partners.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH][next] scsi: hisi_sas: Avoid a couple -Wflex-array-member-not-at-end warnings
Date: Tue, 14 Oct 2025 18:19:25 -0400 [thread overview]
Message-ID: <yq1frblb09r.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <0e46139a-bb80-4684-977d-aaacc653840b@embeddedor.com> (Gustavo A. R. Silva's message of "Tue, 7 Oct 2025 11:54:23 +0100")
Gustavo,
>>> struct {
>>> - struct ssp_command_iu task;
>>> u32 prot[PROT_BUF_SIZE];
>>> + struct ssp_command_iu task;
>>> };
>
> Actually, I have a question here:
>
> is u32 prot[PROT_BUF_SIZE]; intended to overlap flex array
> task.add_cdb[] at some point?
>
> if not, this change is just fine. Otherwise, I'd need to update this
> patch to account for the overlap.
I am not familiar with the hisi hardware interface so I don't know
whether the overlap is intentional.
--
Martin K. Petersen
prev parent reply other threads:[~2025-10-14 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 12:17 [PATCH][next] scsi: hisi_sas: Avoid a couple -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-10-07 10:45 ` Gustavo A. R. Silva
2025-10-07 10:54 ` Gustavo A. R. Silva
2025-10-14 22:19 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1frblb09r.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liyihang9@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox