* [PATCH resend] scsi: smartpqi: add missed free_irq in suspend
@ 2019-12-03 11:13 Chuhong Yuan
2019-12-10 0:06 ` Martin K. Petersen
2020-01-20 16:24 ` Don.Brace
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-12-03 11:13 UTC (permalink / raw)
Cc: Don Brace, James E . J . Bottomley, Martin K . Petersen,
esc.storagedev, linux-scsi, linux-kernel, Chuhong Yuan
The driver calls request_irq in resume but does not call free_irq in
suspend.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 7b7ef3acb504..2251c39afb1b 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -8078,6 +8078,8 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat
pqi_ctrl_wait_for_pending_io(ctrl_info, NO_TIMEOUT);
pqi_stop_heartbeat_timer(ctrl_info);
+ free_irq(pci_irq_vector(pci_dev, 0), &ctrl_info->queue_groups[0]);
+
if (state.event == PM_EVENT_FREEZE)
return 0;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] scsi: smartpqi: add missed free_irq in suspend
2019-12-03 11:13 [PATCH resend] scsi: smartpqi: add missed free_irq in suspend Chuhong Yuan
@ 2019-12-10 0:06 ` Martin K. Petersen
2020-01-20 16:24 ` Don.Brace
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-12-10 0:06 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Don Brace, James E . J . Bottomley, Martin K . Petersen,
esc.storagedev, linux-scsi, linux-kernel
> The driver calls request_irq in resume but does not call free_irq in
> suspend.
> Add the missed call to fix it.
Microsemi: Please review!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH resend] scsi: smartpqi: add missed free_irq in suspend
2019-12-03 11:13 [PATCH resend] scsi: smartpqi: add missed free_irq in suspend Chuhong Yuan
2019-12-10 0:06 ` Martin K. Petersen
@ 2020-01-20 16:24 ` Don.Brace
1 sibling, 0 replies; 3+ messages in thread
From: Don.Brace @ 2020-01-20 16:24 UTC (permalink / raw)
To: hslester96
Cc: don.brace, jejb, martin.petersen, esc.storagedev, linux-scsi,
linux-kernel
-----Original Message-----
The driver calls request_irq in resume but does not call free_irq in suspend.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
NAK: free_irq is called in pqi_resume after checking for correct power state change. (in pqi_free_interrupts())
Thanks for your review,
Don
---
drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 7b7ef3acb504..2251c39afb1b 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -8078,6 +8078,8 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat
pqi_ctrl_wait_for_pending_io(ctrl_info, NO_TIMEOUT);
pqi_stop_heartbeat_timer(ctrl_info);
+ free_irq(pci_irq_vector(pci_dev, 0),
+ &ctrl_info->queue_groups[0]);
+
if (state.event == PM_EVENT_FREEZE)
return 0;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-03 11:13 [PATCH resend] scsi: smartpqi: add missed free_irq in suspend Chuhong Yuan
2019-12-10 0:06 ` Martin K. Petersen
2020-01-20 16:24 ` Don.Brace
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox