From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CCFC742A1 for ; Fri, 12 Jul 2019 00:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 178E4214AF for ; Fri, 12 Jul 2019 00:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="yHAKyxQK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730637AbfGLAe1 (ORCPT ); Thu, 11 Jul 2019 20:34:27 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:48786 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728582AbfGLAe1 (ORCPT ); Thu, 11 Jul 2019 20:34:27 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0YMD3093743; Fri, 12 Jul 2019 00:34:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=/lQHEmys1qaQnVNW3UTZmc01E9PfoBxYGBIwnpGj+/I=; b=yHAKyxQKOlP5Sy4CAxzDqv3ad+tfs1YwJot7br+9fLkPn5TA7armxs0lZROZVQH+7GbI HXwmDGH8OaHPwOFlTt8P6f+kCSGo7D31/ZyNubRZ0sE+aPsMiKFNxHEKPcNtJSqYi89v 4nK+OqplKWOLkPY7TYPc+l8HHCs/jtVfDuGL+8MSZ1LQHEIOM8EezlvDU5w5N0+qURJc C3TZIsG17wQzfpo59OrLCgJrdYY1tYmNjrHdnRz1v7xqvm9xTtdhFQzDc72GEh+7sRNP 0F6lbOaVLR2aGEXGwu0j+DNe0NuQyDe1M8iX74jqWVBYpmFcend/V6aQa11ypszKfYaU eA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2tjm9r2u93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:34:22 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0XSEk013674; Fri, 12 Jul 2019 00:34:22 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2tn1j1ue14-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:34:22 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6C0YKrY017875; Fri, 12 Jul 2019 00:34:21 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Jul 2019 17:34:20 -0700 To: Denis Efremov Cc: Dan Williams , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libsas: remove the exporting of sas_wait_eh From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190708164339.14465-1-efremov@linux.com> Date: Thu, 11 Jul 2019 20:34:18 -0400 In-Reply-To: <20190708164339.14465-1-efremov@linux.com> (Denis Efremov's message of "Mon, 8 Jul 2019 19:43:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120005 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120005 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Denis, > The function sas_wait_eh is declared static and marked > EXPORT_SYMBOL, which is at best an odd combination. Because the > function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c > file it is defined in, this commit removes the EXPORT_SYMBOL() marking. Applied to 5.3/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering