From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D859C5ACC6 for ; Tue, 16 Oct 2018 21:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1CB721471 for ; Tue, 16 Oct 2018 21:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="42wzndhT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1CB721471 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbeJQFk3 (ORCPT ); Wed, 17 Oct 2018 01:40:29 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50700 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbeJQFk2 (ORCPT ); Wed, 17 Oct 2018 01:40:28 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9GLgN5x164966; Tue, 16 Oct 2018 21:47:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=NrHK+MxNjToU03arzs1UghHP/TenzW/WRqL+bWjt5Xk=; b=42wzndhTHH4Qf+/ZRMvhGbkJnF4XRe0ZpnrKvXjmJixvXWM/sBboihaHE7g5gHvAjsV4 KLIdZQdX4IhkKils1psGv6n/QQK15XRG226zt9y3K8jl+ZUPygyHPHhCqiQdMNhXKLEW qhAi1m4Kv27XVVltoxGE+T5eVD8GWQSZwaashzacc54NtMFs5kZIM5yNq+oz16MA3XBs fDKBOzCzlByBR3fwsV0R8/3NxuTRZNefTh5jH+m7MosAOyaSPSqFqsz74WMej+l6alyR DuEmItQ1tfNtCmaesgdPa2LnHZJ4db4O8wPchONAaWy7Kaj9bKxS4LjD6d9XQ34ku2zk VQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2n39brbc55-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Oct 2018 21:47:51 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9GLlj2d016260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Oct 2018 21:47:45 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9GLliKi032125; Tue, 16 Oct 2018 21:47:44 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 16 Oct 2018 14:47:44 -0700 To: "Gustavo A. R. Silva" Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: ips: fix missing break in switch From: "Martin K. Petersen" Organization: Oracle Corporation References: <20181016091223.GA19765@embeddedor.com> Date: Tue, 16 Oct 2018 17:47:42 -0400 In-Reply-To: <20181016091223.GA19765@embeddedor.com> (Gustavo A. R. Silva's message of "Tue, 16 Oct 2018 11:12:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9048 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=476 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810160181 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gustavo, > Add missing break statement in order to prevent the code from falling > through to case TEST_UNIT_READY. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering