From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757403AbdLUCYZ (ORCPT ); Wed, 20 Dec 2017 21:24:25 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:45020 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755899AbdLUCYX (ORCPT ); Wed, 20 Dec 2017 21:24:23 -0500 To: Cathy Avery Cc: kys@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, sthemmin@microsoft.com, haiyangz@microsoft.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, longli@microsoft.com Subject: Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error From: "Martin K. Petersen" Organization: Oracle Corporation References: <1513708368-25951-1-git-send-email-cavery@redhat.com> Date: Wed, 20 Dec 2017 21:24:10 -0500 In-Reply-To: <1513708368-25951-1-git-send-email-cavery@redhat.com> (Cathy Avery's message of "Tue, 19 Dec 2017 13:32:48 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8751 signatures=668651 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=518 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712210029 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cathy, > When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN > which has zero good_bytes it must be assigned an error. Otherwise the > I/O will be continuously requeued and will cause a deadlock in the > case where disks are being hot added and removed. sd_probe_async will > wait forever for its I/O to complete while holding > scsi_sd_probe_domain. > > Also returning the default error of DID_TARGET_FAILURE causes > multipath to not retry the I/O resulting in applications receiving I/O > errors before a failover can occur. Applied to 4.15/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering